Skip to content

Bump spotless #126125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

Bump spotless #126125

merged 3 commits into from
Apr 2, 2025

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Apr 2, 2025 •
edited
Loading

I don't think there's anything that requires that we stay on an old version of this, so I'm bumping it. 🤷

@joegallo joegallo added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v8.19.0 labels Apr 2, 2025
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Apr 2, 2025
@joegallo joegallo marked this pull request as ready for review April 2, 2025 14:38
@joegallo joegallo requested a review from a team as a code owner April 2, 2025 14:38
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@joegallo joegallo merged commit 1306c6b into elastic:main Apr 2, 2025
18 checks passed
@joegallo joegallo deleted the bump-spotless branch April 2, 2025 17:07
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts
❌ 7.17 Commit could not be cherrypicked due to conflicts
❌ 8.17 Commit could not be cherrypicked due to conflicts
❌ 8.16 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126125

@joegallo joegallo mentioned this pull request Apr 2, 2025
Closed
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Apr 2, 2025
@joegallo
Bump spotless (elastic#126125)
848ae70
This was referenced Apr 2, 2025
Closed
Closed
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Apr 2, 2025
@joegallo
Bump spotless (elastic#126125)
fc672ff
@joegallo joegallo mentioned this pull request Apr 2, 2025
Merged
joegallo added a commit that referenced this pull request Apr 2, 2025
@joegallo
[7.17] Bump spotless (#126125) (#126160)
cf683b5
@joegallo
Copy link
Contributor Author

joegallo commented Apr 2, 2025

Uh oh, this is actually causing builds to hang -- I noticed it on one of my backport PRs, but now that I'm looking for it, I'm also seeing it on PRs against main (where my PR to version bump did not hang, naturally).

Screenshot 2025-04-02 at 4 32 30 PM

I talked to @brianseeders about this, and he and I agreed that I should run through and do some reverts, so I'm going to do that and hopefully we'll get ordinary PRs unblocked. Since he was interested in upgrading spotless anyway, he'll take a look at seeing if he can figure out why things are hanging, and then take another swing at this once that seems to be reliably addressed.

joegallo added a commit to joegallo/elasticsearch that referenced this pull request Apr 2, 2025
@joegallo
Revert "[7.17] Bump spotless (elastic#126125) (elastic#126160)"
750f1cb 
This reverts commit cf683b5.
@joegallo joegallo mentioned this pull request Apr 2, 2025
Merged
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Apr 2, 2025
@joegallo
Revert "Bump spotless (elastic#126125)"
7d03384 
This reverts commit 1306c6b.
@joegallo joegallo mentioned this pull request Apr 2, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 2, 2025
@joegallo
Revert "[7.17] Bump spotless (#126125) (#126160)" (#126172)
2c26c65 
Reverting #126160, which
was a backport of #126125,
due to
#126125 (comment).
elasticsearchmachine pushed a commit that referenced this pull request Apr 2, 2025
@joegallo
Revert "Bump spotless (#126125)" (#126173)
552066e 
Reverting #126125 due to
#126125 (comment).
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
@joegallo @andreidan
Bump spotless (elastic#126125)
e4edf0a
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
@joegallo @andreidan
Revert "Bump spotless (elastic#126125)" (elastic#126173)
f138bc7 
Reverting elastic#126125 due to
elastic#126125 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >non-issue serverless-linked Added by automation, don't add manually Team:Delivery Meta label for Delivery team v7.17.29 v8.16.7 v8.17.5 v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joegallo @elasticsearchmachine @brianseeders