[Failure Store] Add missing feature flag check in RBACEngineTests #126215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slobodanadamovic
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Apr 3, 2025
Contributor
n1v0lg
left a comment
n1v0lg
left a comment
There was a problem hiding this comment.
I've done a terrible job with these 😅 Thanks for fixing. There's one more I think:
testAllowedActionsMatcherWithSelectors
slobodanadamovic
added
the
auto-merge-without-approval
slobodanadamovic
deleted the
sa-failure-store-hide-rbac-tests-feature-flag
branch
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 8, 2025
…astic#126215) Resolves elastic#126130 (cherry picked from commit 3affea3) # Conflicts: # muted-tests.yml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 8, 2025
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #126130