Skip to content

[Failure Store] Add missing feature flag check in RBACEngineTests #126215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

[Failure Store] Add missing feature flag check in RBACEngineTests #126215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b11ce
[Failure Store] Add missing feature flag check in RBACEngineTests
slobodanadamovic Apr 3, 2025
5979bf0
hide testAllowedActionsMatcherWithSelectors behind feature flag as well
slobodanadamovic Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,6 @@ tests:
- class: org.elasticsearch.search.basic.SearchWithRandomDisconnectsIT
method: testSearchWithRandomDisconnects
issue: https://github.com/elastic/elasticsearch/issues/122707
- class: org.elasticsearch.xpack.security.authz.RBACEngineTests
method: testBuildUserPrivilegeResponseCombinesIndexPrivileges
issue: https://github.com/elastic/elasticsearch/issues/126130
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/126139
Expand Down
1 change: 1 addition & 0 deletions ...plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/RBACEngineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,7 @@ public void testBuildUserPrivilegeResponse() {
}

public void testBuildUserPrivilegeResponseCombinesIndexPrivileges() {
assumeTrue("failure store feature must be enabled", DataStream.isFailureStoreFeatureFlagEnabled());
final BytesArray query = new BytesArray("""
{"term":{"public":true}}""");
final Role role = Role.builder(RESTRICTED_INDICES, "test", "role")
Expand Down