Skip to content

Fix deploying custom models with adaptive allocations #126276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Fix deploying custom models with adaptive allocations #126276

merged 2 commits into from
Apr 4, 2025

Conversation

jan-elastic
Copy link
Contributor

No description provided.

@jan-elastic jan-elastic added >non-issue :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 v8.17.5 labels Apr 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

jan-elastic
jan-elastic commented Apr 4, 2025
View reviewed changes
.../xpack/inference/services/elasticsearch/CustomElandInternalTextEmbeddingServiceSettings.java

CustomElandInternalTextEmbeddingServiceSettings(
int numAllocations,
Integer numAllocations,
Copy link
Contributor Author

@jan-elastic jan-elastic Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting adaptive allocations (and thereby passing numAllocations = null) currently doesn't work for custom models. The parent constructor also has Integer numAllocations.

jonathan-buttner
jonathan-buttner approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Jan, maybe add a test to ensure we don't break this in the future.

@jan-elastic jan-elastic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 4, 2025
@elasticsearchmachine elasticsearchmachine merged commit 1927c6e into main Apr 4, 2025
18 checks passed
@elasticsearchmachine elasticsearchmachine deleted the fix-custom-model-adaptive-allocs branch April 4, 2025 14:50
This was referenced Apr 4, 2025
Merged
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0
✅ 8.17

elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
@jan-elastic
Fix deploying custom models with adaptive allocations (#126276) (#126315
c873479 
)
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
@jan-elastic
Fix deploying custom models with adaptive allocations (#126276) (#126316
db2be04 
)
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
@jan-elastic
Fix deploying custom models with adaptive allocations (#126276) (#126317
813f7e2 
)
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
@jan-elastic
Fix deploying custom models with adaptive allocations (#126276) (#126318
7eb8224 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

@davidkyle davidkyle

@jonathan-buttner jonathan-buttner

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.17.5 v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jan-elastic @elasticsearchmachine @jonathan-buttner @davidkyle