Skip to content

Fix deploying custom models with adaptive allocations #126276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Fix deploying custom models with adaptive allocations #126276

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5ae0c
Fix deploying custom models with adaptive allocations
jan-elastic Apr 4, 2025
b367a59
add test
jan-elastic Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ack/inference/services/elasticsearch/CustomElandInternalTextEmbeddingServiceSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ private static CommonFields commonFieldsFromMap(Map<String, Object> map, Validat
private final DenseVectorFieldMapper.ElementType elementType;

CustomElandInternalTextEmbeddingServiceSettings(
int numAllocations,
Integer numAllocations,
Copy link
Contributor Author

@jan-elastic jan-elastic Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting adaptive allocations (and thereby passing numAllocations = null) currently doesn't work for custom models. The parent constructor also has Integer numAllocations.

int numThreads,
String modelId,
AdaptiveAllocationsSettings adaptiveAllocationsSettings,
Expand Down