Remove usages of TransportMessage
#126375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This base class is kinda pointless: everywhere it's used we can either be more specific (e.g. choosing between `TransportRequest` or `TransportResponse`) or more general (e.g. choosing `Writeable`). This commit removes all the usages apart from the `extends` clauses of its direct descendants.
DaveCTurner
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 7, 2025
This base class is kinda pointless: everywhere it's used we can either be more specific (e.g. choosing between `TransportRequest` or `TransportResponse`) or more general (e.g. choosing `Writeable`). This commit removes all the usages apart from the `extends` clauses of its direct descendants.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
This base class is kinda pointless: everywhere it's used we can either be more specific (e.g. choosing between `TransportRequest` or `TransportResponse`) or more general (e.g. choosing `Writeable`). This commit removes all the usages apart from the `extends` clauses of its direct descendants.
mridula-s109
pushed a commit
that referenced
this pull request
Apr 7, 2025
This base class is kinda pointless: everywhere it's used we can either be more specific (e.g. choosing between `TransportRequest` or `TransportResponse`) or more general (e.g. choosing `Writeable`). This commit removes all the usages apart from the `extends` clauses of its direct descendants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This base class is kinda pointless: everywhere it's used we can either
be more specific (e.g. choosing between
TransportRequestorTransportResponse) or more general (e.g. choosingWriteable). Thiscommit removes all the usages apart from the
extendsclauses of itsdirect descendants.