Fix SearchErrorTraceIT and friends to work with batched query execution #127150
Conversation
Making this work with batched execution and fixing a memory leak: * Fix memory leak by removing listener on first message. There really only is a single message here per node anyway with batched execution in the mix. Either it's a single shard on the data node and we get a single query message or it's multiple shards and we get a single batched message, so fine to remove listener after the first message since all tests do a single request only anyway. * Add a new hook that allows inspection of the actual response. This is needed for batched since batched sends a non-error response even if the data node failed all searches. We had this before in the `onResponseSent` hook but checking the instance after it's been sent over the wire causes needless overhead in the production code so moving to a "before-style" hook here.
original-brownbear
added
>test
elasticsearchmachine
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| * @param action the request action | ||
| * @param response response instance | ||
| */ | ||
| default void onBeforeResponseSent(long requestId, String action, TransportResponse response) {} |
There was a problem hiding this comment.
@DaveCTurner wdyt? this should be ok right? In prod the overhead is negligible I think.
test/framework/src/main/java/org/elasticsearch/search/ErrorTraceHelper.java
Outdated
Show resolved
Hide resolved
#125163 see this PR, we were wasting memory holding on to the message just for the noop (in production) hook :) I dropped the holding on to the message till after it's fully flushed to the wire in that PR. |
|
@DaveCTurner I'm looking to merge this but am still curious what you think about this additional method call in OutboundHandler (as Armin previously asked). I don't have a good feel for how performance-sensitive we are at that layer... |
Pretty performance-sensitive but I think we can tolerate this change. |
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
|
@elasticmachine run elasticsearch-ci |
|
@elasticmachine run elasticsearch-ci |
|
@elasticmachine run elasticsearch-ci |
|
@elasticmachine run Elasticsearch Serverless Checks |
|
@elasticmachine run Elasticsearch Serverless Checks |
|
@elasticmachine run Elasticsearch Serverless Checks |
|
Forked: #132227 |
6 participants
Making this work with batched execution and fixing a memory leak:
onResponseSenthook but checking the instance after it's been sent over the wire causes needless overhead in the production code so moving to a "before-style" hook here.part of #125788