Reduce flakiness of cartesian centroid tests #127857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
GalLalouche
approved these changes
May 8, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 8, 2025
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 8, 2025
This was referenced May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
This was referenced May 8, 2025
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 8, 2025
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartesian centroids involve much more floating point rounding errors than geo-centroids (since geo are restricted to a small specific range of values). We've fixed this before, but there seems to be a long tail of rare failures.
The test was muted on main, but also reported in 8.17 in #124609, so I'm backporting all the way back.
Fixes #124609