Reapply "Adds unused lower level ivf knn query (#127852)" (#128003) #128052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
richard-dennehy
pushed a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
May 19, 2025
…stic#128003) (elastic#128052) * Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003) This reverts commit 648d74b. * Fixing tests
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
May 20, 2025
…stic#128003) (elastic#128052) * Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003) This reverts commit 648d74b. * Fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reapplies reversion. This also contains a test fix where we would periodically set
numVectorsPerClusterto0, which is disallowed.closes: #127963
closes: #127941
closes: #127969
closes: #128002