ES|QL: Fix constant folding when using FORK #128276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #127209
Because the FORK output is a union of the subplans' outputs and we keep the same
Attributeobjects, we don't always apply the right optimizations.Take this query for example:
When we apply constant folding, we incorrectly determine that the
aattribute from the lastWHEREcondition is a constant. In cases like these we either end up not returning any rows or we return the output of both FORK branches.To fix this, the FORK output will no longer reuse the same
Attributeobjects from the fork subplans when we do the union of output attributes.Instead FORK will output a new set of attributes that have the same name and type but with different IDs (in a way similar to STATS).