-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Implementing copy_sign function for ESQL #128281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
adf71de
Implementing copy_sign function for ESQL
pabloem 5133010
enforcing floating point only for CopySign operation
pabloem e05a7e5
Merge branch 'main' into pabloem-copy-sign
pabloem f486892
Merge branch 'main' into pabloem-copy-sign
pabloem fb665fe
Merge branch 'main' into pabloem-copy-sign
pabloem aa4d54b
Merge branch 'main' into pabloem-copy-sign
pabloem 53d4fac
Merge branch 'main' into pabloem-copy-sign
pabloem 7cbb7f9
fixup
pabloem 61aa123
fix count test
pabloem 095210c
fixup
pabloem e3a5a98
test checks
pabloem bfbd48c
[CI] Auto commit changes from spotless
85c3d83
casting
pabloem 255d5a9
fix checkstyle
pabloem ad9ecc6
figured types out and set it up
pabloem 6774a30
Merge branch 'main' into pabloem-copy-sign
pabloem ea553b5
pass some classes
pabloem 112bb00
Merge branch 'main' into pabloem-copy-sign
pabloem cbddc41
try again
pabloem 4f3155f
Merge branch 'main' into pabloem-copy-sign
pabloem e786889
Merge branch 'main' into pabloem-copy-sign
pabloem c5bdd94
address comments
pabloem fd30ff7
comments
pabloem 907bff1
fixup
pabloem 0f3e4f6
fix docs
pabloem ac0fa59
Merge branch 'main' into pabloem-copy-sign
pabloem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
147 changes: 147 additions & 0 deletions
147
...org/elasticsearch/xpack/esql/expression/function/scalar/math/CopySignDoubleEvaluator.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
148 changes: 148 additions & 0 deletions
148
.../org/elasticsearch/xpack/esql/expression/function/scalar/math/CopySignFloatEvaluator.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.