Skip to content

Conversation

@pabloem
Copy link
Contributor

@pabloem pabloem commented May 21, 2025

Implementing copy_sign

@pabloem pabloem force-pushed the pabloem-copy-sign branch 3 times, most recently from 7c63288 to 2f91dad Compare May 22, 2025 05:27
@pabloem pabloem force-pushed the pabloem-copy-sign branch from 2f91dad to 7e053c9 Compare May 22, 2025 17:43
@nik9000
Copy link
Member

nik9000 commented May 22, 2025

@pabloem pabloem force-pushed the pabloem-copy-sign branch 3 times, most recently from 7c63288 to 2f91dad

Once you've opened the PR try not to force push to it. We squash and rebase on merge so the commits don't make it into the main branch. And reviewers can use the commits to follow along. Don't worry about crafting them carefully, but it is useful to have them.

@pabloem pabloem force-pushed the pabloem-copy-sign branch from 60d7b63 to c80bd11 Compare May 22, 2025 19:37
@pabloem
Copy link
Contributor Author

pabloem commented May 22, 2025

Once you've opened the PR try not to force push to it. We squash and rebase on merge so the commits don't make it into the main branch. And reviewers can use the commits to follow along. Don't worry about crafting them carefully, but it is useful to have them.

ah yes my bad! I was force-pushing my initial changes (before any review) - I'll avoid it in the future

@nik9000
Copy link
Member

nik9000 commented May 22, 2025

ah yes my bad! I was force-pushing my initial changes (before any review) - I'll avoid it in the future

Eh. It's no big deal. Sometimes you have to. But I tend to never force push any PRs so I never have to worry about if someone is looking yet. Just less stuff for me to even remember.

@pabloem pabloem force-pushed the pabloem-copy-sign branch from c80bd11 to 5133010 Compare May 23, 2025 23:07
@pabloem pabloem force-pushed the pabloem-copy-sign branch from 4ff9932 to ad9ecc6 Compare June 2, 2025 20:08
@pabloem pabloem marked this pull request as ready for review June 3, 2025 14:03
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 3, 2025
@pabloem pabloem added the :Analytics/ES|QL AKA ESQL label Jun 3, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Jun 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@pabloem pabloem removed the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 3, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 3, 2025
@pabloem pabloem added the >new-field-mapper Added when a new field type / mapper is being introduced label Jun 3, 2025
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I withdraw my main question. I requested a few comments and formatting things, but feel free to merge as soon as you think you've done enough there. No need to wait on me unless you think one of my requests is way off base.

import java.util.Map;

/**
* ES|QL function that mimics the behavior of Math.copySign(double magnitude, double sign).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code Math.copySign(double magnitude, double sign)} for make this render nicely on mouseover and in the actual generated docs. No one reads those. But we do read the mouseovers.

@pabloem pabloem enabled auto-merge (squash) June 3, 2025 23:14
@pabloem pabloem merged commit 7c22694 into elastic:main Jun 4, 2025
17 of 18 checks passed
@pabloem pabloem deleted the pabloem-copy-sign branch June 4, 2025 00:31
@nik9000 nik9000 mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >new-field-mapper Added when a new field type / mapper is being introduced Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants