Handle quotes in gradle arguments

[idegtiarenko]

When executing .ci/scripts/run-gradle.sh -p benchmarks/ run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json' I was getting following error:

FAILURE: Build failed with an exception.
* What went wrong:
Problem configuring task :benchmarks:run from command line.
> Unknown command-line option '-r'.

...

https://gradle-enterprise.elastic.co/s/37zyldvhgnbze

I believe this is happening due to quotes in the command. unlike $@, "$@" should preserve quotes.

[elasticsearchmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[idegtiarenko]

Please let me know if additional testing (besides main pipeline) is required for this change

[breskeby]

Seems reasonable to me. Have you tested running the pipeline that caused this issue to verify it fixes your problem?

[breskeby]

LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?

[breskeby]

LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?

[breskeby]

👍

[breskeby]

I've asked @brianseeders to have a look at this too as his bash foo is beyond mine and he authored that initially i think

[brianseeders]

Yep, that should be quoted. Thank you.

[idegtiarenko]

LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?

@breskeby it looks liek we are having troubles running this pipeline from the fork, see https://buildkite.com/elastic/elasticsearch-periodic-micro-benchmarks/builds/2#019715e2-e8bc-4e64-ba51-482fd7afa1e9

However I was able to reproduce the issue locally and confirm this is fixing it.

[breskeby]

FYI. @idegtiarenko you should be able to run branches that are linked to a PR by just passing a branch in the pattern of pull/128548/head to run pipelines like this even from a branch/pr

[idegtiarenko]

Ah, makes sense, I was trying {fork}:{branch} instead