Skip to content

Handle quotes in gradle arguments #128548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

Handle quotes in gradle arguments #128548

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2285f
Handle quotes in gradle arguments
idegtiarenko May 28, 2025
da56da3
Update gradle command
idegtiarenko May 28, 2025
42a964b
Merge branch 'main' into handle_quotes
idegtiarenko May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipelines/periodic-micro-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
steps:
- label: periodic-micro-benchmarks
command: |
.ci/scripts/run-gradle.sh -p benchmarks/ run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json'
.ci/scripts/run-gradle.sh :benchmarks:run --args 'org.elasticsearch.benchmark._nightly -rf json -rff build/result.json'
Copy link
Contributor

@breskeby breskeby May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

timeout_in_minutes: 300
agents:
provider: gcp
Expand Down
2 changes: 1 addition & 1 deletion .ci/scripts/run-gradle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ else
fi

set -e
$GRADLEW -S --max-workers=$MAX_WORKERS $@
$GRADLEW -S --max-workers=$MAX_WORKERS "$@"
Copy link
Contributor Author

@idegtiarenko idegtiarenko May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if additional testing (besides main pipeline) is required for this change

Copy link
Contributor

@breskeby breskeby May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Have you tested running the pipeline that caused this issue to verify it fixes your problem?

Copy link
Contributor

@breskeby breskeby May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. have you manually triggered the pipeline that failed from the patch branch to verify the fix works here too?