Skip to content

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented May 28, 2025

This PR adds some additional instrumentation to ensure we capture more cases in which we use async network usage via Selectors

@ldematte ldematte added >non-issue auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels May 28, 2025
@ldematte ldematte marked this pull request as ready for review May 29, 2025 08:28
@ldematte ldematte requested a review from a team as a code owner May 29, 2025 08:28
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte ldematte force-pushed the entitlements/nio-async-network-instrumentation branch from 3db0837 to b7e917d Compare May 29, 2025 09:16
Copy link
Contributor

@prdoyle prdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. If it turns out other plugins need these entitlements, we'll get an alert soon enough. 😅

@ldematte ldematte enabled auto-merge (squash) May 29, 2025 13:05
@ldematte ldematte merged commit 554b96a into elastic:main May 29, 2025
17 of 18 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128582

prdoyle pushed a commit to prdoyle/elasticsearch that referenced this pull request May 29, 2025
…#128582)

This PR adds some additional instrumentation to ensure we capture more cases in which we use async network usage via channels and `select`
@prdoyle
Copy link
Contributor

prdoyle commented May 29, 2025

Backporting here: #128629

elasticsearchmachine pushed a commit that referenced this pull request May 30, 2025
#128629)

This PR adds some additional instrumentation to ensure we capture more cases in which we use async network usage via channels and `select`

Co-authored-by: Lorenzo Dematté <[email protected]>
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
…#128582)

This PR adds some additional instrumentation to ensure we capture more cases in which we use async network usage via channels and `select`
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
…#128582)

This PR adds some additional instrumentation to ensure we capture more cases in which we use async network usage via channels and `select`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants