Skip to content

Add docs for index component selector api convention #128786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2025
Merged

Add docs for index component selector api convention #128786

merged 6 commits into from
Jun 26, 2025
+33 −0

Conversation

@jbaiera
Copy link
Member

@jbaiera jbaiera commented Jun 2, 2025

Adds documentation for index component selectors to the reference docs.

This documentation references and will be referenced by new docs located at elastic/docs-content#1368

@jbaiera jbaiera added >docs General docs changes :Data Management/Data streams Data streams and their lifecycles v8.19.0 v9.1.0 labels Jun 2, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jun 2, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 2, 2025

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 2, 2025

Pinging @elastic/es-data-management (Team:Data Management)

@jbaiera jbaiera requested review from dakrone and kilfoyle June 2, 2025 21:28
@jbaiera jbaiera mentioned this pull request Jun 2, 2025
Merged
dakrone
dakrone approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general shape and structure LGTM. I left some suggestions, but this is a hard topic to talk about with simplicity, so I wouldn't take any of them as dogmatic.

kilfoyle
kilfoyle reviewed Jun 3, 2025
View reviewed changes
kilfoyle
kilfoyle reviewed Jun 3, 2025
View reviewed changes
kilfoyle
kilfoyle approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Added just a few small suggestions.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025 •
edited
Loading

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

dakrone
dakrone approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM still, thanks Jimmy!

@jbaiera jbaiera merged commit e54cd63 into elastic:main Jun 26, 2025
8 of 9 checks passed
@jbaiera jbaiera deleted the docs-index-selector branch June 26, 2025 20:47
@reakaleek
Copy link
Member

reakaleek commented Jun 26, 2025 •
edited
Loading

The docs-build is failing on main because docs-content://manage-data/data-store/data-streams/failure-store.md does not exit yet.

@jbaiera
Copy link
Member Author

jbaiera commented Jun 26, 2025

Sorry! This PR was tied up with elastic/docs-content#1368 and needed both to be merged to work. Looks like both are now.

@reakaleek
Copy link
Member

reakaleek commented Jun 26, 2025

Np. @shainaraskas temporarily removed the crosslink in elastic/docs-content#1368 so that the page officially exists. Now the docs-build is green again. ✌️

smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jun 27, 2025
@jbaiera @kilfoyle @smalyshev
Add docs for index component selector api convention (elastic#128786)
acdc25c 
Co-authored-by: David Kilfoyle <[email protected]>
@georgewallace georgewallace added the auto-backport Automatically create backport pull requests when merged label Jul 1, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 3, 2025
@jbaiera @kilfoyle @mridula-s109
Add docs for index component selector api convention (elastic#128786)
e1d3629 
Co-authored-by: David Kilfoyle <[email protected]>
@shainaraskas shainaraskas mentioned this pull request Jul 22, 2025
Merged
@shainaraskas shainaraskas added the docs-missing-applies-tags PRs that are missing docs applies_to tags for an upcoming release. label Jul 22, 2025
This was referenced Aug 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@dakrone dakrone dakrone approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles >docs General docs changes docs-missing-applies-tags PRs that are missing docs applies_to tags for an upcoming release. Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.19.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jbaiera @elasticsearchmachine @reakaleek @dakrone @kilfoyle @georgewallace @shainaraskas