ESQL: Assert no partial results in integration tests #129293

bpintea · 2025-06-11T19:33:49Z

This injects assertions in spec-based and YAML integration tests that the received results aren't partial.
This only happens in case the tests themselves don't set "allow_partial_results": true.

Closes #129256

This injects assertions in spec-based and YAML integration tests that the received results aren't partial. This only happens in case the tests themselves don't set `"allow_partial_results": true`

nik9000 · 2025-06-12T12:07:33Z

...ugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java

        Map<String, Object> answer = runEsql(builder.query(query), testCase.assertWarnings(deduplicateExactWarnings()));

+        var isPartial = answer.get("is_partial");
+        assertTrue("unexpected partial results", isPartial == null || (boolean) isPartial == false);


Might be easier to read with assertThat(..., anyOf(is(false), nullValue())). Dunno. Your call.

Yes, better, thanks.

nik9000 · 2025-06-12T12:08:26Z

.../yamlRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/AbstractEsqlClientYamlIT.java

+                var apiCallSection = doSection.getApiCallSection();
+                if (apiCallSection.getApi().equals("esql.query")) {
+                    // If `allow_partial_results` is explicitly set to true, partial results are allowed.
+                    // If it's missing, no partial results are expected, even if the parameter's default is true.


It's a bit of magic, I think it's a pretty reasonable sacrifice.

dnhatn

Thanks so much, @bpintea. I wonder if we should also do this for other QA modules (multi-node, multi-nodes, mixed-cluster).

dnhatn · 2025-06-12T16:39:16Z

...ugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java


+        var isPartial = answer.get("is_partial");
+        assertTrue("unexpected partial results", isPartial == null || (boolean) isPartial == false);
+


nit: can we also extract the failures and throw them?

Good idea, I've extracted _clusters contents into the assertion message (we don't have more otherwise).

…ial_results

bpintea · 2025-06-17T14:07:51Z

I wonder if we should also do this for other QA modules (multi-node, multi-nodes, mixed-cluster).

The changes apply to those suites too.

elasticsearchmachine · 2025-06-17T14:08:29Z

Pinging @elastic/es-analytical-engine (Team:Analytics)

bpintea · 2025-06-17T15:44:48Z

Thanks Nik and Nhat.

elasticsearchmachine · 2025-06-17T15:47:11Z

💔 Backport failed

Status	Branch	Result
❌	8.19	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129293

This injects assertions in spec-based and YAML integration tests that the received results aren't partial. This only happens in case the tests themselves don't set "allow_partial_results": true. Closes #129256 (cherry picked from commit d51d643)

This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293

…0213) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: elastic#129293

…130332) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293

…130338) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293 (cherry picked from commit 7836826)

…0213) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: elastic#129293

Assert no partial results in integration tests

c3a4155

This injects assertions in spec-based and YAML integration tests that the received results aren't partial. This only happens in case the tests themselves don't set `"allow_partial_results": true`

bpintea added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.19.0 v9.1.0 labels Jun 11, 2025

Fix naming typo

83f8a59

bpintea mentioned this pull request Jun 12, 2025

ESQL: Run tests with allow_partial_results set to false #129271

Closed

nik9000 approved these changes Jun 12, 2025

View reviewed changes

dnhatn approved these changes Jun 12, 2025

View reviewed changes

bpintea added 2 commits June 17, 2025 13:53

Review comments

ada9bf2

Merge remote-tracking branch 'upstream/main' into test/assert_no_part…

e2ef257

…ial_results

bpintea mentioned this pull request Jun 17, 2025

ESQL: partial failure in few KNN tests #129550

Closed

Mute now failing tests

471beea

bpintea marked this pull request as ready for review June 17, 2025 14:08

elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 17, 2025

bpintea added the auto-backport Automatically create backport pull requests when merged label Jun 17, 2025

bpintea merged commit d51d643 into elastic:main Jun 17, 2025
26 of 27 checks passed

bpintea deleted the test/assert_no_partial_results branch June 17, 2025 15:45

elasticsearchmachine added the backport pending label Jun 17, 2025

alex-spies mentioned this pull request Jun 18, 2025

[CI] EsqlSpecIT test {knn-function.KnnSearchWithKOption SYNC} failing #129512

Closed

bpintea mentioned this pull request Jun 27, 2025

ESQL: Extend the check on partial results to all REST ITs #130213

Merged

elasticsearchmachine pushed a commit that referenced this pull request Jun 30, 2025

ESQL: Extend the check on partial results to all REST ITs (#130213)

7836826

This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293

elasticsearchmachine pushed a commit that referenced this pull request Jun 30, 2025

ESQL: Extend the check on partial results to all REST ITs (#130213) (#…

2b01c9e

…130332) This extends the check that no partial results are returned to the rest of the JSON-based REST ITs. Related: #129293

bpintea mentioned this pull request Jun 30, 2025

[8.19] ESQL: Extend the check on partial results to all REST ITs (#130213) #130338

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ESQL: Assert no partial results in integration tests #129293

ESQL: Assert no partial results in integration tests #129293

Uh oh!

bpintea commented Jun 11, 2025

Uh oh!

nik9000 Jun 12, 2025

Uh oh!

bpintea Jun 17, 2025

Uh oh!

nik9000 Jun 12, 2025

Uh oh!

dnhatn left a comment

Uh oh!

dnhatn Jun 12, 2025

Uh oh!

bpintea Jun 17, 2025 •

edited

Loading

Uh oh!

bpintea commented Jun 17, 2025

Uh oh!

elasticsearchmachine commented Jun 17, 2025

Uh oh!

bpintea commented Jun 17, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		var isPartial = answer.get("is_partial");
		assertTrue("unexpected partial results", isPartial == null \|\| (boolean) isPartial == false);

ESQL: Assert no partial results in integration tests #129293

ESQL: Assert no partial results in integration tests #129293

Uh oh!

Conversation

bpintea commented Jun 11, 2025

Uh oh!

nik9000 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

bpintea Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

nik9000 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

dnhatn left a comment

Choose a reason for hiding this comment

Uh oh!

dnhatn Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

bpintea Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bpintea commented Jun 17, 2025

Uh oh!

elasticsearchmachine commented Jun 17, 2025

Uh oh!

bpintea commented Jun 17, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jun 17, 2025

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bpintea Jun 17, 2025 •

edited

Loading