-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Assert no partial results in integration tests #129293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
c3a4155
83f8a59
ada9bf2
e2ef257
471beea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -273,6 +273,9 @@ protected final void doTest(String query) throws Throwable { | |
| Map<?, ?> prevTooks = supportsTook() ? tooks() : null; | ||
| Map<String, Object> answer = runEsql(builder.query(query), testCase.assertWarnings(deduplicateExactWarnings())); | ||
|
|
||
| var isPartial = answer.get("is_partial"); | ||
| assertTrue("unexpected partial results", isPartial == null || (boolean) isPartial == false); | ||
|
||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: can we also extract the failures and throw them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea, I've extracted |
||
| var expectedColumnsWithValues = loadCsvSpecValues(testCase.expectedResults); | ||
|
|
||
| var metadata = answer.get("columns"); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit of magic, I think it's a pretty reasonable sacrifice.