Fix TextFieldBlockLoaderTests test assumption. #129361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are in order as was provided during indexing. Closes elastic#128012 Closes elastic#128011
martijnvg
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
added
the
auto-backport
kkrik-es
approved these changes
Jun 12, 2025
dnhatn
approved these changes
Jun 12, 2025
…e_above`. Also improved blockLoaderResult assertion by making it readable when it fails.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jul 7, 2025
Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are sometimes in order as was provided during indexing. Actual fix was to check for `synthetic_source_keep` instead of `ignore_above`. Also improved blockLoaderResult assertion by making it readable when it fails. Closes elastic#128012 Closes elastic#128011
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jul 7, 2025
Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are sometimes in order as was provided during indexing. Actual fix was to check for `synthetic_source_keep` instead of `ignore_above`. Also improved blockLoaderResult assertion by making it readable when it fails. Closes elastic#128012 Closes elastic#128011
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 7, 2025
Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are sometimes in order as was provided during indexing. Actual fix was to check for `synthetic_source_keep` instead of `ignore_above`. Also improved blockLoaderResult assertion by making it readable when it fails. Closes #128012 Closes #128011
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 7, 2025
) * Fix TextFieldBlockLoaderTests test assumption. (#129361) Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are sometimes in order as was provided during indexing. Actual fix was to check for `synthetic_source_keep` instead of `ignore_above`. Also improved blockLoaderResult assertion by making it readable when it fails. Closes #128012 Closes #128011 * fix compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test assumes that values from keyword doc values fields are in sorted order, but that is no longer the case and values are in order as was provided during indexing.
Closes #128012
Closes #128011