Skip to content

Fix TextFieldBlockLoaderTests test assumption. #129361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 7, 2025
Merged

Fix TextFieldBlockLoaderTests test assumption. #129361

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
de17431
Fix TextFieldBlockLoaderTests test assumption.
martijnvg Jun 12, 2025
b727827
only sort if ignore above isn't set.
martijnvg Jun 13, 2025
0c87aee
[CI] Auto commit changes from spotless
Jun 13, 2025
a9731b1
remove sys.out
martijnvg Jun 13, 2025
b6f5810
Merge remote-tracking branch 'es/main' into fix_TextFieldBlockLoaderT…
martijnvg Jun 20, 2025
8dafc10
Improved assertion failure message and more logging, if the test fail…
martijnvg Jun 20, 2025
91541fb
iter
martijnvg Jun 20, 2025
2a8f8da
Merge remote-tracking branch 'es/main' into fix_TextFieldBlockLoaderT…
martijnvg Jul 4, 2025
363c784
Actual fix was to check for `synthetic_source_keep` instead of `ignor…
martijnvg Jul 5, 2025
f1d6261
Merge remote-tracking branch 'es/main' into fix_TextFieldBlockLoaderT…
martijnvg Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...r/src/test/java/org/elasticsearch/index/mapper/blockloader/TextFieldBlockLoaderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
import org.elasticsearch.datageneration.FieldType;
import org.elasticsearch.index.mapper.BlockLoaderTestCase;

import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -82,12 +80,6 @@ public static Object expectedValue(Map<String, Object> fieldMapping, Object valu
.map(BytesRef::new)
.collect(Collectors.toList());

if (store == false) {
// using doc_values for synthetic source
indexed = new ArrayList<>(new HashSet<>(indexed));
indexed.sort(BytesRef::compareTo);
}

// ignored values always come last
List<BytesRef> ignored = values.stream()
.map(s -> s == null ? nullValue : s)
Expand Down