[ML] Custom service adding support for the semantic text field #129558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>refactoring
:ml
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Jun 18, 2025
|
|
||
| private static final RateLimitSettings DEFAULT_RATE_LIMIT_SETTINGS = new RateLimitSettings(10_000); | ||
| private static final String RESPONSE_SCOPE = String.join(".", ModelConfigurations.SERVICE_SETTINGS, RESPONSE); | ||
| private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 1; |
There was a problem hiding this comment.
Is a batch of 1 still a batch?
Suggested change
| private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 1; | |
| private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 10; |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
…ic#129558) * Adding chunking tests * adjusting default batch size
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
…ic#129558) * Adding chunking tests * adjusting default batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback item from the original PR: #127939
This PR adds support for the semantic text field by adding chunking functionality.
Comments:
#127939 (comment)