Move docker image to registry to address flaky test #129660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution.
ankit--sethi
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ankit--sethi
added
auto-backport
slobodanadamovic
approved these changes
Jun 23, 2025
Contributor
slobodanadamovic
left a comment
slobodanadamovic
left a comment
There was a problem hiding this comment.
LGTM 👍
Nice job!
ankit--sethi
added a commit
to ankit--sethi/elasticsearch
that referenced
this pull request
Jun 23, 2025
* Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution. * fix name
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 23, 2025
* Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as #126694 and also speed up execution. * fix name
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
* Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution. * fix name
Contributor
|
@ankit--sethi wondering if we should backport your PR to 9.0 as well -- since it's a test we can still backport to that branch. Getting a failure from 9.0 (#130461). |
Contributor
Author
Oh I should have added 9.0 in the first place, I'll work on that backport today |
ankit--sethi
added a commit
to ankit--sethi/elasticsearch
that referenced
this pull request
Jul 8, 2025
* Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution. * fix name (cherry picked from commit 22390d7)
slobodanadamovic
pushed a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Jul 14, 2025
…lastic#129878) * Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution. * fix name (cherry picked from commit eec192f) # Conflicts: # x-pack/test/smb-fixture/src/main/java/org/elasticsearch/test/fixtures/smb/SmbTestContainer.java
This was referenced Jul 14, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 14, 2025
… (#131178) * Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as #126694 and also speed up execution. * fix name (cherry picked from commit eec192f) # Conflicts: # x-pack/test/smb-fixture/src/main/java/org/elasticsearch/test/fixtures/smb/SmbTestContainer.java Co-authored-by: Ankit Sethi <[email protected]>
ankit--sethi
added a commit
to ankit--sethi/elasticsearch
that referenced
this pull request
Jul 16, 2025
* Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as elastic#126694 and also speed up execution. * fix name (cherry picked from commit 22390d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new Docker image on-the-fly, it is better to create a persistent image and upload it to Docker Registry. This will help tests dependent on this image be resilient to transient issues such as #126694 and also speed up execution.
I've added a new docker image for this fixture:
