-
Couldn't load subscription status.
- Fork 25.6k
Run TransportClusterStateAction on local node
#129872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This action solely needs the cluster state, it can run on any node. Since this action is invoked across clusters, we need to be able to (de)serialize requests and responses. We introduce a new `RemoteClusterStateRequest` that wraps the existing `ClusterStateRequest` and implements (de)serialization.
server/src/main/java/org/elasticsearch/action/ActionModule.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/state/RemoteClusterStateRequest.java
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @nielsbauman, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of comments
server/src/internalClusterTest/java/org/elasticsearch/cluster/NoMasterNodeIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/ActionModule.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/state/ClusterStateRequest.java
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/state/RemoteClusterStateRequest.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/state/RemoteClusterStateRequest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The shard started may not be visible on the master node if the wait is on a data node. In that case, the DiskThreshold monitor may use stale cluster state for releasing read-only blocks. This PR fixes it by waiting on the master node, which is the behaviour before elastic#129872. Resolves: elastic#131146
The shard started may not be visible on the master node if the wait is on a data node. In that case, the DiskThreshold monitor may use stale cluster state for releasing read-only blocks. This PR fixes it by waiting on the master node, which is the behaviour before elastic#129872. Resolves: elastic#131146
The shard started may not be visible on the master node if the wait is on a data node. In that case, the DiskThreshold monitor may use stale cluster state for releasing read-only blocks. This PR fixes it by waiting on the master node, which is the behaviour before elastic#129872. Resolves: elastic#131146
This action solely needs the cluster state, it can run on any node. Since this action is invoked across clusters, we need to be able to (de)serialize requests and responses. We introduce a new
RemoteClusterStateRequestthat wraps the existingClusterStateRequestand implements (de)serialization.