ES|QL: Account for CB memory when loading fields from source #129998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
force-pushed
the
heap_attack_large_strings
branch
5 times, most recently
from
0517d57 to
e7afc90
Compare
luigidellaquila
force-pushed
the
heap_attack_large_strings
branch
from
e7afc90 to
e140119
Compare
elasticsearchmachine
added
the
needs:triage
luigidellaquila
commented
Jul 1, 2025
| assertCircuitBreaks(attempt -> fetchManyBigFields(attempt * 500)); | ||
| } | ||
|
|
||
| public void testStatsOnLargeKeywords() throws IOException { |
There was a problem hiding this comment.
This test is terribly flaky.
Sometimes the query succeeds without circuit breaking, sometimes it fails with OOM.
Running the query multiple times makes the thing even worse.
The minimum memory differences between stateful and serverless make it very hard to tune.
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving circuit breaker memory accounting when extracting field values (
TEXT, typically) from _source.With this change we try to approximate the memory used, based on the source size.