- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25.6k
ES|QL: Account for CB memory when loading fields from source #129998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            luigidellaquila
  wants to merge
  14
  commits into
  elastic:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
luigidellaquila:heap_attack_large_strings
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 12 commits
      Commits
    
    
            Show all changes
          
          
            14 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2fa902f
              
                Account for CB memory when loading fields from source
              
              
                luigidellaquila df298e5
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila eb08f57
              
                Fix NPE
              
              
                luigidellaquila aaca661
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila 66a2735
              
                No space left on device (CI)...
              
              
                luigidellaquila 5c8cf25
              
                Too big for CI
              
              
                luigidellaquila afdb0f3
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila 6dfa02d
              
                Tuning test for CI
              
              
                luigidellaquila c6014c9
              
                Fine tune for Serverless
              
              
                luigidellaquila f9d32ba
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila 49cf607
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila e140119
              
                Reduce test size
              
              
                luigidellaquila 2a76237
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila 3a4deed
              
                Merge branch 'main' into heap_attack_large_strings
              
              
                luigidellaquila File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is terribly flaky.
Sometimes the query succeeds without circuit breaking, sometimes it fails with OOM.
Running the query multiple times makes the thing even worse.
The minimum memory differences between stateful and serverless make it very hard to tune.