Add tests and docs for first/last_over_time and rate #130290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔍 Preview links for changed docs:
🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
dnhatn
changed the title
dnhatn
added
:StorageEngine/TSDB
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
stratoula
reviewed
Jun 30, 2025
There was a problem hiding this comment.
How easy it is to add a flag to indicate that these are working only with the TS source command? Otherwise I will have to hardcode them at kibana
Member
Author
There was a problem hiding this comment.
"type" : "time_series_agg",
The time-series aggregation type is time_series_agg, whereas the type of other aggregations is agg. I can add a new flag too.
There was a problem hiding this comment.
Oh I see!! No this will work Nhat! Thanx a ton! I totally missed it 🙈
kkrik-es
reviewed
Jun 30, 2025
| examples = { @Example(file = "k8s-timeseries", tag = "rate") } | ||
| ) | ||
| public Rate(Source source, @Param(name = "field", type = { "counter_long", "counter_integer", "counter_double" }) Expression field) { | ||
| this(source, field, new UnresolvedAttribute(source, "@timestamp")); |
Contributor
There was a problem hiding this comment.
We don't need to resolve the timestamp in this field?
leemthompo
reviewed
Jun 30, 2025
Comment on lines
+69
to
+76
| :::{include} ../_snippets/functions/layout/first_over_time.md | ||
| ::: | ||
|
|
||
| :::{include} ../_snippets/functions/layout/last_over_time.md | ||
| ::: | ||
|
|
||
| :::{include} ../_snippets/functions/layout/rate.md | ||
| ::: |
Contributor
There was a problem hiding this comment.
@dnhatn I see you actually have used applies_to in this PR 👍
BTW curious why you didn't chose to just not include the docs here (thus not publish them) as opposed to publishing them with unavailable markers
It's very early days with the new docs system and just wanna make sure we have somewhat consistent approaches :)
Member
Author
There was a problem hiding this comment.
Thanks @leemthompo. I opened #130367 to delay publishing these pages until we are ready.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
This PR adds unit tests and docs for first_over_time, last_over_time, and rate. For the rate function, the tests currently only verify that the output is a double, not the actual value.
3 tasks
9 tasks
stratoula
added a commit
to elastic/kibana
that referenced
this pull request
Jul 9, 2025
## Summary Closes #220730 Supports of TS inner agg functions. 1. Retrieves the functions and the docs from elastic/elasticsearch#130290 2. Suggest them only when an agg is already selected and only if the source command is TS  Atm you won't see any changes in the editor. You can test it though if you change the `src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/time_series_agg_functions.ts` `ignoreAsSuggestion` flags to false. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Vadim Kibana <[email protected]>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Closes elastic#220730 Supports of TS inner agg functions. 1. Retrieves the functions and the docs from elastic/elasticsearch#130290 2. Suggest them only when an agg is already selected and only if the source command is TS  Atm you won't see any changes in the editor. You can test it though if you change the `src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/time_series_agg_functions.ts` `ignoreAsSuggestion` flags to false. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Vadim Kibana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests and docs for first_over_time, last_over_time, and rate. For the rate function, the tests currently only verify that the output is a double, not the actual value.