ES|QL: add tests and fix docs for LOOKUP JOIN with index datemath #130535
Conversation
luigidellaquila
added
>docs
|
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
🔍 Preview links for changed docs |
| } | ||
|
|
||
| public void testDateMathIndexPattern() throws IOException { | ||
| ZonedDateTime now = ZonedDateTime.now(ZoneOffset.UTC); |
There was a problem hiding this comment.
Using now may lead to flakiness when the tests are executed around midnight, no? Maybe a fixed date would be better?
There was a problem hiding this comment.
I thought about it, but date math is all about dynamic patterns using now. I'm not sure a test with a fixed date will be realistic.
There was a problem hiding this comment.
One thing I can do is to use the year only, that should drastically reduce the risk of flakiness
There was a problem hiding this comment.
How long does this test runs?
I have seen some sql/eql examples that add assumption they are executed at least 10-15 minutes before midnight.
@alex-spies yes, we have tests, but I completely misread them. We explicitly disallow the usage of |
luigidellaquila
added
auto-backport
| request.addParameter("refresh", "true"); | ||
| request.setJsonEntity("{\"f\":" + idx++ + "}"); | ||
| assertOK(client().performRequest(request)); | ||
| } |
There was a problem hiding this comment.
I think this might need a refresh.
I wonder if we have anything similar to indexRandom for the RestTestCases?
💚 Backport successful
|
5 participants
Adding tests and fixing docs for usage of date math in index patterns, especially in LOOKUP JOIN, that got recent support for aliases.