Skip to content

Remove unnecessary double loop of centroids in hkmeans #130579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Remove unnecessary double loop of centroids in hkmeans #130579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions server/src/main/java/org/elasticsearch/index/codec/vectors/cluster/HierarchicalKMeans.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,11 @@ KMeansIntermediate clusterAndSplit(final FloatVectorValues vectors, final int ta
// TODO: consider adding cluster size counts to the kmeans algo
// handle assignment here so we can track distance and cluster size
int[] centroidVectorCount = new int[centroids.length];
int effectiveK = 0;
for (int assigment : assignments) {
centroidVectorCount[assigment]++;
}

int effectiveK = 0;
for (int j : centroidVectorCount) {
if (j > 0) {
// this cluster has received an assignment, its now effective, but only count it once
if (centroidVectorCount[assigment] == 1) {
effectiveK++;
}
}
Expand Down