Use isSearchable instead of checking if a shard can be promoted.
#130601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>refactoring
:StorageEngine/Downsampling
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Jul 4, 2025
| */ | ||
| private boolean isEligible(ShardRouting shardRouting) { | ||
| return shardRouting.started() && (isStateless ? shardRouting.isPromotableToPrimary() == false : shardRouting.primary()); | ||
| return shardRouting.started() && (isStateless ? shardRouting.isSearchable() : shardRouting.primary()); |
There was a problem hiding this comment.
In stateless, this would return false in indexing tier?
There was a problem hiding this comment.
According to the code I checked, this is determined based on the role of the shard, for example, an indexing shard is not searchable while a search shard is.
I think this should be sufficient, given that we trust that the searchable shard is assigned to the searching tier. In the end, downsampling needs a shard that can be searched, where that shard is allocated is a consequence of this, right?
There was a problem hiding this comment.
Right and I think in case of stateless this is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #130160 .
Use
isSearchableinstead of negatingisPromotableToPrimarybecause it better captures what we need.For non stateless deployments, we preserve the current logic to downsample the primary. This can change in the future but we should think through if there are any implications.