Skip to content

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented Jul 7, 2025

manual backport of #129983 to fix #129888

- match: {esql.functions.coalesce: $functions_coalesce}
- gt: {esql.functions.categorize: $functions_categorize}
- length: {esql.functions: 146} # check the "sister" test above for a likely update to the same esql.functions length check
- length: {esql.functions: 137} # check the "sister" test above for a likely update to the same esql.functions length check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that both these changes are good by running these tests in non-snapshot mode

 ./gradlew ":x-pack:plugin:yamlRestTest" --tests "org.elasticsearch.xpack.test.rest.XPackRestIT.test {p0=esql/60_usage/*}" -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dlicense.key=x-pack/license-tools/src/test/resources/public.key

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioanatia ioanatia merged commit d9c537f into elastic:9.1 Jul 7, 2025
32 checks passed
@ioanatia ioanatia deleted the backport_esql_usage_fix branch July 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport >non-issue :Search Relevance/Search Catch all for Search Relevance Team:Search - Relevance The Search organization Search Relevance team v9.1.0 v9.1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants