Move project-related tests from MetadataTests to ProjectMetadataTests
#130846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts` The main goal was to get rid of loads of usages of deprecated methods in `Metadata` and its builder, but I figured it made more sense to move these tests to a more appropriate test class. These changes mainly consist of a copy-paste from one test class to another, and using `ProjectMetadata` objects (and its builders) instead of `Metadata` objects.
nielsbauman
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ywangd
approved these changes
Jul 11, 2025
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
I didn't compare each individual methods that got moved. But the overall list of methods make sense to me and it should be safe enough as long as CI passes.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…sts` (elastic#130846) The main goal was to get rid of loads of usages of deprecated methods in `Metadata` and its builder, but I figured it made more sense to move these tests to a more appropriate test class. These changes mainly consist of a copy-paste from one test class to another, and using `ProjectMetadata` objects (and its builders) instead of `Metadata` objects.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…sts` (elastic#130846) The main goal was to get rid of loads of usages of deprecated methods in `Metadata` and its builder, but I figured it made more sense to move these tests to a more appropriate test class. These changes mainly consist of a copy-paste from one test class to another, and using `ProjectMetadata` objects (and its builders) instead of `Metadata` objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal was to get rid of loads of usages of deprecated methods in
Metadataand its builder, but I figured it made more sense to movethese tests to a more appropriate test class. These changes mainly
consist of a copy-paste from one test class to another, and using
ProjectMetadataobjects (and its builders) instead ofMetadataobjects.