-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ES|QL: Add note in Known Issues for #130644 #130996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES|QL: Add note in Known Issues for #130644 #130996
Conversation
🔍 Preview links for changed docs |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
To mitigate this issue, the disk space checker is disabled by default in 9.0.3 by setting `indices.merge.disk.check_interval` to `0` seconds. Manually enabling this setting is not recommended. | ||
|
||
This issue is planned to be fixed in future patch release [#129613](https://github.com/elastic/elasticsearch/pull/129613) | ||
This issue is planned to be fixed in future patch release [#129613](https://github.com/elastic/elasticsearch/pull/129613) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leemthompo the problem is there since 8.16, so also in 9.0.0.
Should the note be in 9.0.0 section instead? What is the best practice here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry, I mean the new note of course, two lines below...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luigidellaquila I think the best practice is to add the known issue to all affected versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be hard to do for all the 8.x versions, but probably manageable for the 9.x versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I wonder if we added a known issues section (or link) in the ESQL limitations page that would be helpful too? Just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best practice is to add the known issue to all affected versions
OK, I'm adding the same note in the 9.0.0 section.
I wonder if we added a known issues section (or link) in the ESQL limitations page that would be helpful too?
I think it makes sense. Probably, in terms of maintenance effort, a link to the known issues is easier to manage. My concern is that we could end up with misalignments if we duplicate information.
I'm adding a new section, please have a look if you have a chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luigidellaquila just some very minor wording suggestions :)
To mitigate this issue, the disk space checker is disabled by default in 9.0.3 by setting `indices.merge.disk.check_interval` to `0` seconds. Manually enabling this setting is not recommended. | ||
|
||
This issue is planned to be fixed in future patch release [#129613](https://github.com/elastic/elasticsearch/pull/129613) | ||
This issue is planned to be fixed in future patch release [#129613](https://github.com/elastic/elasticsearch/pull/129613) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Thanks @leemthompo ! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Manual backport to 9.0 #131097 |
Add a note in Known Issue about a bug with ES|QL STATS, see #130644