-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ES|QL: Add note in Known Issues for #130644 #130996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luigidellaquila
merged 8 commits into
elastic:main
from
luigidellaquila:esql/known_bug_stats
Jul 11, 2025
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1dde95e
Add note in Known Issues for #130644
luigidellaquila 200ea23
Implement suggestions
luigidellaquila 90f8579
Update docs/release-notes/known-issues.md
luigidellaquila e29650d
Update docs/release-notes/known-issues.md
luigidellaquila fa69062
Update docs/release-notes/known-issues.md
luigidellaquila 3462cce
Update docs/release-notes/known-issues.md
luigidellaquila b72be71
Update docs/release-notes/known-issues.md
luigidellaquila 0bd351f
Fix wording
luigidellaquila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leemthompo the problem is there since 8.16, so also in 9.0.0.
Should the note be in 9.0.0 section instead? What is the best practice here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry, I mean the new note of course, two lines below...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luigidellaquila I think the best practice is to add the known issue to all affected versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be hard to do for all the 8.x versions, but probably manageable for the 9.x versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I wonder if we added a known issues section (or link) in the ESQL limitations page that would be helpful too? Just thinking out loud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'm adding the same note in the 9.0.0 section.
I think it makes sense. Probably, in terms of maintenance effort, a link to the known issues is easier to manage. My concern is that we could end up with misalignments if we duplicate information.
I'm adding a new section, please have a look if you have a chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM