Fix concurrent list in merge test #131186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingherc
added
:Distributed Indexing/Engine
kingherc
force-pushed
the
test-issue/131165-merge-conc-list
branch
2 times, most recently
from
567334c to
cd18376
Compare
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
kingherc
force-pushed
the
test-issue/131165-merge-conc-list
branch
from
cd18376 to
3822909
Compare
albertzaharovits
approved these changes
Jul 15, 2025
Contributor
albertzaharovits
left a comment
albertzaharovits
left a comment
There was a problem hiding this comment.
I would've used a concurrent set in order to avoid synchronizing before the iteration (which is not important for the test correctness).
More importantly, don't forget to unmute the test.
Contributor
Author
|
Thanks @albertzaharovits ! Forgot to unmute, did just now, and used concurrent Sets instead. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport versions were picked based on PR that introduced the test in #129613 .
Fixes #131165