Throw better exception if verifying empty repo #131677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
ywangd
approved these changes
Jul 22, 2025
|
|
||
| static void ensureValidGenId(long repositoryGenId) { | ||
| if (repositoryGenId == RepositoryData.EMPTY_REPO_GEN) { | ||
| throw new IllegalArgumentException("repository is empty, cannot verify its integrity"); |
There was a problem hiding this comment.
Nit: I think there is "no need" to verify its integrity instead of "cannot". The later is technically correct due to the negative number. But the former reads more friendly and helpful. It might even be OK to return empty response here. But an exception seems slightly more preferrable.
There was a problem hiding this comment.
I know what you mean, but my rationale for using "cannot" here is that the user has probably made a mistake with their repository config to get to this point (e.g. incorrect bucket or base path) - that seems much more likely than a user just wanting to check a totally empty bucket for integrity violations.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of elastic#131677 to `9.1`
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of elastic#131677 to `9.0`
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of elastic#131677 to `8.19`
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of elastic#131677 to `8.18`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of #131677 to `9.0`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of #131677 to `8.19`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of #131677 to `8.18`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
Today if you attempt to verify the integrity of a brand-new repository
(no `index-${N}` blob) then it will fail because the repository
generation is `-1` which cannot be sent over the wire. But it makes no
sense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.
Backport of #131677 to `9.1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if you attempt to verify the integrity of a brand-new repository
(no
index-${N}blob) then it will fail because the repositorygeneration is
-1which cannot be sent over the wire. But it makes nosense to verify the integrity of such a repository anyway, so with this
commit we fail such requests up-front with a more helpful error message.