- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
[ML] Inference services - remove unused init method #131759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Pinging @elastic/ml-core (Team:ML)  | 
    
| protected static final Set<TaskType> COMPLETION_ONLY = EnumSet.of(TaskType.COMPLETION); | ||
| private final Sender sender; | ||
| private final ServiceComponents serviceComponents; | ||
| private final ClusterService clusterService; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR: https://github.com/elastic/elasticsearch/pull/131551/files#diff-7ac70d182c5505ff84ebb34581462f562d52780c090b60ce80e665476819d4ccR76
Is planning on using the ClusterService.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment on the PR
| 
           run Elasticsearch Serverless Checks  | 
    
The
init()method is not called by anyone