Skip to content

[ML] Inference services - remove unused init method #131759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 27, 2025
Merged

[ML] Inference services - remove unused init method #131759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90499bc
Remove unused init method
davidkyle Jul 23, 2025
8e30dd6
Remove unused cluster service from the SenderService
davidkyle Jul 23, 2025
534a396
[CI] Auto commit changes from spotless
Jul 23, 2025
acccb17
Revert "Remove unused cluster service from the SenderService"
davidkyle Aug 26, 2025
7386b76
Merge branch 'main' into inference-api-cleanup
davidkyle Aug 26, 2025
2f7fe25
Merge branch 'main' into inference-api-cleanup
davidkyle Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions server/src/main/java/org/elasticsearch/inference/InferenceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import org.elasticsearch.TransportVersion;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.client.internal.Client;
import org.elasticsearch.core.Nullable;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.inference.validation.ServiceIntegrationValidator;
Expand All @@ -24,8 +23,6 @@

public interface InferenceService extends Closeable {

default void init(Client client) {}

String name();

/**
Expand Down
5 changes: 0 additions & 5 deletions server/src/main/java/org/elasticsearch/inference/InferenceServiceRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

package org.elasticsearch.inference;

import org.elasticsearch.client.internal.Client;
import org.elasticsearch.common.io.stream.NamedWriteableRegistry;

import java.io.Closeable;
Expand Down Expand Up @@ -42,10 +41,6 @@ public InferenceServiceRegistry(
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
}

public void init(Client client) {
services.values().forEach(s -> s.init(client));
}

public void onNodeStarted() {
for (var service : services.values()) {
try {
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferencePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ public Collection<?> createComponents(PluginServices services) {
// This must be done after the HttpRequestSenderFactory is created so that the services can get the
// reference correctly
var serviceRegistry = new InferenceServiceRegistry(inferenceServices, factoryContext);
serviceRegistry.init(services.client());
for (var service : serviceRegistry.getServices().values()) {
service.defaultConfigIds().forEach(modelRegistry.get()::addDefaultIds);
}
Expand Down