Skip to content

weight() vs count() in ApiKeyService.java #131777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 4, 2025
Merged

weight() vs count() in ApiKeyService.java #131777

merged 11 commits into from
Sep 4, 2025

Conversation

@mjmbischoff
Copy link
Contributor

@mjmbischoff mjmbischoff commented Jul 23, 2025 •
edited
Loading

  • use weight vs count

encountered / spun out of #130964

@mjmbischoff
Update cache weight calculations
4dbe9aa 
- use `long`
- use weight vs count
- prevent (unlikely) overflow
@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 23, 2025
mjmbischoff added a commit to mjmbischoff/elasticsearch that referenced this pull request Jul 23, 2025
@mjmbischoff
Reverting changes to ApiKeyService as it's spun out into it's own PR e…
efc5e20 
…lastic#131777
@mjmbischoff mjmbischoff changed the title Update cache weight calculations Update cache weight setting logic and calculations in ApiKeyService.java Jul 23, 2025
@mjmbischoff mjmbischoff marked this pull request as ready for review July 23, 2025 22:14
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 23, 2025
@mjmbischoff mjmbischoff added the :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) label Jul 24, 2025
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@mjmbischoff mjmbischoff added >bug needs:triage Requires assignment of a team area label and removed Team:Security Meta label for security team labels Jul 24, 2025
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @mjmbischoff, I've created a changelog YAML for you.

@mjmbischoff mjmbischoff self-assigned this Jul 25, 2025
@mjmbischoff mjmbischoff added the auto-backport Automatically create backport pull requests when merged label Jul 31, 2025
@mjmbischoff mjmbischoff requested a review from ywangd August 28, 2025 19:56
@mjmbischoff mjmbischoff requested a review from ywangd August 29, 2025 11:32
@mjmbischoff mjmbischoff changed the title Update cache weight setting logic and calculations in ApiKeyService.java weight() vs count() in ApiKeyService.java Aug 29, 2025
@ywangd ywangd removed the auto-backport Automatically create backport pull requests when merged label Aug 31, 2025
ywangd
ywangd reviewed Aug 31, 2025
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please make sure CI is green before merging. Thanks!
Btw, I removed the auto-backport label since I think it does not need backporting.

@mjmbischoff mjmbischoff merged commit 7af81af into elastic:main Sep 4, 2025
39 checks passed
jbaiera pushed a commit to jbaiera/elasticsearch that referenced this pull request Sep 5, 2025
@mjmbischoff @jbaiera
weight() vs count() in ApiKeyService.java (elastic#131777)
8cdfd14 
use weight() vs count()
@mjmbischoff mjmbischoff deleted the ApiKeyService-overflow branch September 5, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

Assignees

@mjmbischoff mjmbischoff

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjmbischoff @elasticsearchmachine @ywangd