-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Multi Match] Refactor QueryIntercepter Rewrite #132026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi Match] Refactor QueryIntercepter Rewrite #132026
Conversation
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @Samiul-TheSoccerFan, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a changelog for this PR. Let's label it as >refactor to remove that.
| public SemanticQueryRewriteInterceptor() {} | ||
|
|
||
| @Override | ||
| public QueryBuilder interceptAndRewrite(QueryRewriteContext context, QueryBuilder queryBuilder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this method are not effectively preparing for the changes that will actually necessary to support multi_match here. I suggest taking some time to think about how you will change this method to properly support multi_match, making an implementation plan, and then determining which parts of that plan can and should be done as part of this initial refactor PR.
|
@elasticmachine update branch |
|
@elasticmachine update branch |
1 similar comment
|
@elasticmachine update branch |
96f7dde to
7cace0b
Compare
|
@elasticmachine update branch |
|
@elasticsearchmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
This PR is the first part of
multi_matchimplementation withsemantic_textfield.This PR includes:
getFieldNameto handlefieldNamealong with its per field boost.