-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Multi Match] Refactor QueryIntercepter Rewrite #132026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Samiul-TheSoccerFan
wants to merge
14
commits into
elastic:main
from
Samiul-TheSoccerFan:refactor-intercept-rewriter-for-multi-match
+123
−34
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
387ca85
update intercept framework to handle per field boost
Samiul-TheSoccerFan 53f9c7a
supply boost into existing intercepter builders
Samiul-TheSoccerFan ba1598a
linting
Samiul-TheSoccerFan 763cc29
Update docs/changelog/132026.yaml
Samiul-TheSoccerFan d0162c7
update changelog
Samiul-TheSoccerFan 32aef7b
Delete docs/changelog/132026.yaml
Samiul-TheSoccerFan df28791
adding multimatch intercepter class
Samiul-TheSoccerFan 44d08bd
remove multimatch interceptor
Samiul-TheSoccerFan e0b939d
remove interceptor registration from plugin
Samiul-TheSoccerFan 7cace0b
working commit
Samiul-TheSoccerFan e5556c8
linting
Samiul-TheSoccerFan 1e1b05f
remove unused field declaration
Samiul-TheSoccerFan 517311b
Merge branch 'main' into refactor-intercept-rewriter-for-multi-match
elasticmachine fe53090
Merge branch 'main' into refactor-intercept-rewriter-for-multi-match
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this method are not effectively preparing for the changes that will actually necessary to support
multi_matchhere. I suggest taking some time to think about how you will change this method to properly supportmulti_match, making an implementation plan, and then determining which parts of that plan can and should be done as part of this initial refactor PR.