Skip to content

ESQL: Mark csv-spec tests #132098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025
Merged

ESQL: Mark csv-spec tests #132098

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c1f2f8d
ESQL: Mark csv-spec tests
nik9000 Jul 29, 2025
f67aeaa
Merge branch 'main' into esql_mark_spec_tests
nik9000 Jul 29, 2025
706cfb5
Merge branch 'main' into esql_mark_spec_tests
nik9000 Jul 30, 2025
f88bf96
Merge branch 'main' into esql_mark_spec_tests
nik9000 Jul 31, 2025
e00112a
Update muted tests after method name changes
nik9000 Jul 31, 2025
39b6594
Merge remote-tracking branch 'nik9000/esql_mark_spec_tests' into esql…
nik9000 Jul 31, 2025
43c81cb
Merge branch 'main' into esql_mark_spec_tests
nik9000 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...i-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public class MultiClusterSpecIT extends EsqlSpecTestCase {
private static RestClient remoteClusterClient;
private static DataLocation dataLocation = null;

@ParametersFactory(argumentFormatting = "%2$s.%3$s")
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s")
public static List<Object[]> readScriptSpec() throws Exception {
List<URL> urls = classpathResources("/*.csv-spec");
assertTrue("Not enough specs found " + urls, urls.size() > 0);
Expand Down
2 changes: 1 addition & 1 deletion ...n/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public abstract class EsqlSpecTestCase extends ESRestTestCase {
protected final Mode mode;
protected static Boolean supportsTook;

@ParametersFactory(argumentFormatting = "%2$s.%3$s %7$s")
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s %7$s")
public static List<Object[]> readScriptSpec() throws Exception {
List<URL> urls = classpathResources("/*.csv-spec");
assertTrue("Not enough specs found " + urls, urls.size() > 0);
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/CsvTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public class CsvTests extends ESTestCase {
private ThreadPool threadPool;
private Executor executor;

@ParametersFactory(argumentFormatting = "%2$s.%3$s")
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s")
public static List<Object[]> readScriptSpec() throws Exception {
List<URL> urls = classpathResources("/*.csv-spec");
assertThat("Not enough specs found " + urls, urls, hasSize(greaterThan(0)));
Expand Down