Skip to content

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 29, 2025

Adds csv-spec: to the name of the test so our test triaging robot can understand when it sees failures of csv-spec tests. Looks like:

test {csv-spec:spatial.AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation}

Adds `csv-spec:` to the name of the test so our test triaging robot can
understand when it sees failures of csv-spec tests. Looks like:
```
test {csv-spec:spatial.AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation}
```
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.2.0 v9.1.1 v8.19.1 labels Jul 29, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@idegtiarenko
Copy link
Contributor

test {csv-spec:spatial.AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation}

Nit:

Is it worth changing to:
test {spatial.csv-spec:AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation}
This way you can see an exact file name and scenario after semicolon? Unless this complicates the work of the robot

@ivancea
Copy link
Contributor

ivancea commented Jul 31, 2025

Maybe we can add this PR fix here: #132256

@nik9000
Copy link
Member Author

nik9000 commented Jul 31, 2025

Maybe we can add this PR fix here: #132256

Merge yours first I think. Yours is actually important.

@nik9000 nik9000 enabled auto-merge (squash) July 31, 2025 14:30
@nik9000 nik9000 merged commit 6917f3f into elastic:main Jul 31, 2025
33 checks passed
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
Adds `csv-spec:` to the name of the test so our test triaging robot can
understand when it sees failures of csv-spec tests. Looks like:
```
test {csv-spec:spatial.AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation}
```
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 15, 2025
* upstream/main: (822 commits)
  Improve Semantic Text Exists Query Tests (elastic#132283)
  Make hierarchical k-means over centroids cheaper (elastic#132316)
  Remove unnecessary listener.delegateFailure in IndexShard#ensureMutable (elastic#132294)
  Add missing release note (elastic#132319)
  Unmute elastic#131803 (elastic#132295)
  Include bytes for live docs in ShardFieldStats (elastic#132232)
  Fix default missing index sort value of data_nanos pre 7.14 (elastic#132162)
  [DiskBBQ] Quantize centroids using 7 bits instead of 4 bits (elastic#132261)
  Use panamized version for windows in Int7VectorScorer (elastic#132311)
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testTooManyByAndOverFields elastic#132310
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testManyDistinctOverFields elastic#132308
  Update 8.17 version to 8.17.10 (elastic#132303)
  Mute org.elasticsearch.datastreams.DataStreamsClientYamlTestSuiteIT test {p0=data_stream/10_basic/Create hidden data stream with match all template} elastic#132298
  Add random queries to logsdb data generation tests (elastic#132109)
  ES|QL Inference runner refactoring (elastic#131986)
  Add basic example to linear-retriever.md (elastic#132196)
  Refactor RemoteClusterService to be multi-project aware (elastic#131894)
  ESQL: Mark csv-spec tests (elastic#132098)
  Mute org.elasticsearch.common.logging.JULBridgeTests testThrowable elastic#132280
  Bump versions after 8.19.0 release
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants