[Test] Actually invoke the listener on failure case #132229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listener is expected to be called on failure case. This PR does that. Resolves: elastic#131979
ywangd
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
approved these changes
Jul 31, 2025
Comment on lines
62
to
64
| var listener = ActionListener.assertAtLeastOnce( | ||
| ActionTestUtils.<AcknowledgedResponse>assertNoSuccessListener(e -> assertTrue(e instanceof IllegalArgumentException)) | ||
| ); | ||
| var listener = ActionListener.assertAtLeastOnce(ActionTestUtils.<AcknowledgedResponse>assertNoSuccessListener(e -> { | ||
| assertTrue(e instanceof IllegalArgumentException); | ||
| })); |
There was a problem hiding this comment.
Nit: I don't think these lines need to be changed - changing the parameter to a lambda block seems redundant.
There was a problem hiding this comment.
Yeah you are right. It was unintentional. Pushed 2716157
ywangd
added
the
auto-merge-without-approval
💚 Backport successful
|
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 31, 2025
The listener is expected to be called on failure case. This PR does that. Resolves: elastic#131979
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 31, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jul 31, 2025
The listener is expected to be called on failure case. This PR does that. Resolves: elastic#131979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listener is expected to be called on failure case. This PR does that.
Resolves: #131979