Skip to content

[Test] Actually invoke the listener on failure case #132229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged

[Test] Actually invoke the listener on failure case #132229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
249946f
[Test] Actually invoke the listener on failure case
ywangd Jul 30, 2025
2716157
remove unwanted change
ywangd Jul 31, 2025
7b554e1
Merge remote-tracking branch 'origin/main' into es-131979-fix
ywangd Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...project/src/test/java/org/elasticsearch/multiproject/action/DeleteProjectActionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ public void testDeleteNonExisting() throws Exception {
var projects = randomList(1, 5, ESTestCase::randomUniqueProjectId);
var deletedProjects = randomSubsetOf(projects);
var state = buildState(projects);
var listener = ActionListener.assertAtLeastOnce(
ActionTestUtils.<AcknowledgedResponse>assertNoSuccessListener(e -> assertTrue(e instanceof IllegalArgumentException))
);
var listener = ActionListener.assertAtLeastOnce(ActionTestUtils.<AcknowledgedResponse>assertNoSuccessListener(e -> {
assertTrue(e instanceof IllegalArgumentException);
}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't think these lines need to be changed - changing the parameter to a lambda block seems redundant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right. It was unintentional. Pushed 2716157

var nonExistingTask = createTask(randomUniqueProjectId(), listener);
var tasks = Stream.concat(Stream.of(nonExistingTask), deletedProjects.stream().map(this::createTask)).toList();
var result = ClusterStateTaskExecutorUtils.executeIgnoringFailures(state, executor, tasks);
var result = ClusterStateTaskExecutorUtils.executeHandlingResults(state, executor, tasks, t -> {}, DeleteProjectTask::onFailure);
for (ProjectId deletedProject : deletedProjects) {
assertNull(result.metadata().projects().get(deletedProject));
assertNull(result.globalRoutingTable().routingTables().get(deletedProject));
Expand Down