Skip to content

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Jul 31, 2025

Fix after #131949

Initially, the test string was: test {file.test SYNC/ASYNC}
After the mentioned PR: test {file.test [ABC0ABCA0:ABC0ABC0]}
With this fix: test {file.test}

@ivancea ivancea requested review from idegtiarenko and nik9000 July 31, 2025 09:49
@ivancea ivancea added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.2.0 labels Jul 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@idegtiarenko
Copy link
Contributor

Initially, the test string was: test {file.test SYNC/ASYNC}
After the mentioned PR: test {file.test [ABC0ABCA0:ABC0ABC0]}
With this fix: test {file.test}

On one side this will not open 2 failures (for SYNC and for ASYNC) when the test fails, on the other side I am wondering if it might be important for us to know in what mode has failure happened? Can we reproduce the mode with the seed?

@ivancea
Copy link
Contributor Author

ivancea commented Jul 31, 2025

@idegtiarenko In theory, yes, the seed should be enough. The mode is now calculated with a random() here: https://github.com/elastic/elasticsearch/pull/131949/files#diff-e5229c7428590a22294db189f7845ae0fadefc37b2154c5da1f1dc85804bcaecR121

@nik9000
Copy link
Member

nik9000 commented Jul 31, 2025

Can we reproduce the mode with the seed?

The seed should be enough, yeah.

@nik9000 nik9000 merged commit 23ad424 into elastic:main Jul 31, 2025
33 checks passed
@ivancea ivancea deleted the fix-esql-spec-test-names branch July 31, 2025 14:31
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants