-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ExtraHop][Qualys GAV] - Fix Cannot execute ILM policy delete step #132387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ExtraHop][Qualys GAV] - Fix Cannot execute ILM policy delete step #132387
Conversation
Pinging @elastic/es-security (Team:Security) |
...va/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java
Outdated
Show resolved
Hide resolved
Hi @ShourieG , I do not think that I am qualified to review this, it looks like github has already selected the a team to review. My only comment is the wrong version. I removed the |
Hi @gmarouli, we would need this to be backported to at least 8.18 and above |
@ShourieG I recommend running |
...va/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (from es-security side - pending green CI and compilation resolving)
Please make sure to get approval from @elastic/kibana-security team as well.
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java
Outdated
Show resolved
Hide resolved
75aff4f
to
1d73e61
Compare
c051db0
to
ae90521
Compare
Hi @elastic/kibana-security, could I get a review/approval on this. |
…lastic#132387) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…lastic#132387) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
…lastic#132387) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
…132387) (#132572) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
…132387) (#132573) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
…132387) (#132571) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc)
@janvi-elastic, We are unblocked from 8.19 and above, 8.18 should be unblocked after discovering reasons for ci-failure |
…step (#132387) (#132574) * [ExtraHop][Qualys GAV] - Fix Cannot execute ILM policy delete step (#132387) This PR focuses on the short term solution which add the logs-extrahop.investigation-* and logs-qualys_gav.asset-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs. (cherry picked from commit 0d7a2cc) * Update KibanaOwnedReservedRoleDescriptors.java added missing imports in KibanaOwnedReservedRoleDescriptors * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
This PR focuses on the short term solution which add the
logs-extrahop.investigation-*
andlogs-qualys_gav.asset-*
indices under thekibana_system
role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PRs.Current behavior:
For Qualys GAV:
For ExtraHop:
Closes - #131825
Similar Issues : elastic/kibana#197390, #116982