Skip to content

Check entitlements for URLClassLoader.newInstance #132725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 1, 2025
Merged

Check entitlements for URLClassLoader.newInstance #132725

merged 7 commits into from
Sep 1, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Aug 12, 2025

No description provided.

@mosche mosche added >non-issue :Core/Infra/Entitlements Entitlements infrastructure auto-backport Automatically create backport pull requests when merged v8.18.6 v9.0.6 v9.1.3 v8.19.3 labels Aug 13, 2025
@mosche mosche marked this pull request as ready for review August 13, 2025 08:07
@mosche mosche requested a review from a team as a code owner August 13, 2025 08:07
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

.../entitlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/JvmActions.java Outdated
}

@EntitlementTest(expectedAccess = PLUGINS)
static void createClassLoaderNewInstance() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to test the overload without the parent classloader (if we can!)

@mosche mosche added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 14, 2025
@elasticsearchmachine elasticsearchmachine merged commit d55a91b into elastic:main Sep 1, 2025
33 checks passed
@mosche mosche deleted the entitlements/classloaderNewInstance branch September 1, 2025 07:26
This was referenced Sep 1, 2025
Merged
Merged
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (elastic#132725)
b7471d8
@mosche mosche mentioned this pull request Sep 1, 2025
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (elastic#132725)
c06c712
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 9.0
✅ 8.18
✅ 8.19

mosche added a commit to mosche/elasticsearch that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (elastic#132725)
de26ea5
mosche added a commit to mosche/elasticsearch that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (elastic#132725)
9942374
elasticsearchmachine pushed a commit that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (#132725) (#133909)
a61f350
elasticsearchmachine pushed a commit that referenced this pull request Sep 1, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (#132725) (#133908)
6509916
elasticsearchmachine pushed a commit that referenced this pull request Sep 1, 2025
@mosche
[8.18] Check entitlements for URLClassLoader.newInstance (#132725) (#…
1bab8d6 
…133910)

* Check entitlements for URLClassLoader.newInstance (#132725)

* fix backport
elasticsearchmachine pushed a commit that referenced this pull request Sep 8, 2025
@mosche
Check entitlements for URLClassLoader.newInstance (#132725) (#133911)
3d8125e
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 11, 2025
@mosche @sarog
Check entitlements for URLClassLoader.newInstance (elastic#132725) (e…
9772b29 
…lastic#133911)
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
@mosche @sarog
Check entitlements for URLClassLoader.newInstance (elastic#132725) (e…
7ac60f7 
…lastic#133911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.7 v8.19.4 v9.0.7 v9.1.4 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosche @elasticsearchmachine @ldematte