Skip to content

Check entitlements for URLClassLoader.newInstance #132725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2025
Merged

Check entitlements for URLClassLoader.newInstance #132725

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77f666c
Check entitlements for URLClassLoader.newInstance
mosche Aug 12, 2025
4332a51
Merge branch 'main' into entitlements/classloaderNewInstance
mosche Aug 12, 2025
8dc8977
Merge branch 'main' into entitlements/classloaderNewInstance
mosche Aug 12, 2025
2a6beca
add test
mosche Aug 14, 2025
814792a
Merge branch 'main' into entitlements/classloaderNewInstance
mosche Aug 14, 2025
a018f91
Merge branch 'main' into entitlements/classloaderNewInstance
mosche Aug 28, 2025
46cb68b
Merge branch 'main' into entitlements/classloaderNewInstance
mosche Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...tlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ public interface EntitlementChecker {

void check$java_net_URLClassLoader$(Class<?> callerClass, String name, URL[] urls, ClassLoader parent, URLStreamHandlerFactory factory);

void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls, ClassLoader parent);

void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls);

void check$java_security_SecureClassLoader$(Class<?> callerClass);

void check$java_security_SecureClassLoader$(Class<?> callerClass, ClassLoader parent);
Expand Down
7 changes: 7 additions & 0 deletions ...titlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/JvmActions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ static void createClassLoader() throws IOException {
}
}

@EntitlementTest(expectedAccess = PLUGINS)
static void createClassLoaderNewInstance() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to test the overload without the parent classloader (if we can!)

try (var classLoader = URLClassLoader.newInstance(new URL[0], RestEntitlementsCheckAction.class.getClassLoader())) {
// intentionally empty, just let the loader close
}
}

@EntitlementTest(expectedAccess = ALWAYS_DENIED)
static void createLogManager() {
new java.util.logging.LogManager() {
Expand Down
10 changes: 10 additions & 0 deletions ...in/java/org/elasticsearch/entitlement/runtime/policy/ElasticsearchEntitlementChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,16 @@ public ElasticsearchEntitlementChecker(PolicyChecker policyChecker) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls, ClassLoader parent) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_security_SecureClassLoader$(Class<?> callerClass) {
policyChecker.checkCreateClassLoader(callerClass);
Expand Down