Skip to content

Optimize CcsCommonYamlTestSuiteIT and unmute tests #132726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2025
Merged

Optimize CcsCommonYamlTestSuiteIT and unmute tests #132726

merged 4 commits into from
Aug 12, 2025

Conversation

drempapis
Copy link
Contributor

@drempapis drempapis commented Aug 12, 2025 •
edited
Loading

This is equivalent to #132720

This PR focuses on optimizing the code executed before each test. Specifically:

  • Initializes and verifies CCS only once

  • Caches the combined features / versions / OS, instead of recomputing per test.

@drempapis drempapis added >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v9.2.0 labels Aug 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

benchaplin
benchaplin approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@benchaplin benchaplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, let's see how it works :)

@drempapis
Copy link
Contributor Author

Thank you @benchaplin for the review!

@benchaplin benchaplin mentioned this pull request Aug 12, 2025
Closed
@drempapis drempapis added auto-backport Automatically create backport pull requests when merged v9.0.0 v9.1.0 labels Aug 12, 2025
@drempapis drempapis merged commit 91bdd04 into elastic:main Aug 12, 2025
33 checks passed
@drempapis drempapis mentioned this pull request Aug 12, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts
✅ 9.1

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 132726

@drempapis drempapis mentioned this pull request Aug 12, 2025
Closed
drempapis added a commit to drempapis/elasticsearch that referenced this pull request Aug 12, 2025
@drempapis
Optimize CcsCommonYamlTestSuiteIT and unmute tests (elastic#132726)
d2da9f0
This was referenced Aug 12, 2025
Closed
Closed
elasticsearchmachine pushed a commit that referenced this pull request Aug 12, 2025
@drempapis
Optimize CcsCommonYamlTestSuiteIT and unmute tests (#132726) (#132743)
72cf7fb
@drempapis drempapis mentioned this pull request Aug 13, 2025
Merged
@cbuescher cbuescher mentioned this pull request Aug 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benchaplin benchaplin benchaplin approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.0.0 v9.1.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drempapis @elasticsearchmachine @benchaplin