Skip to content

ESQL - Fix knn test on multiple shards #132753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosdelest merged 2 commits into from
Aug 13, 2025
Merged

ESQL - Fix knn test on multiple shards #132753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8514f4
Fix test on multiple shards
carlosdelest Aug 12, 2025
50af2db
Merge branch 'main' into tests/esql-knn-fix-prefilter-test
carlosdelest Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/knn-function.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ yellow | [255.0, 255.0, 0.0]
knnWithPrefilter
required_capability: knn_function_v3

from colors metadata _score
| where knn(rgb_vector, [128,128,0], 10) and (match(color, "olive") or match(color, "green"))
| sort _score desc, color asc
| keep color, rgb_vector
from colors
| where knn(rgb_vector, [120,180,0], 10) and (match(color, "olive") or match(color, "green"))
| sort color asc
| keep color
Copy link
Member

@kderusso kderusso Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably still keep the rgb_vector data for this test even if we're no longer sorting on score?

Copy link
Member Author

@carlosdelest carlosdelest Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could - however, I don't see the point as we don't need to check scores here, so it doesn't serve any debugging purpose.

;

color:text | rgb_vector:dense_vector
olive | [128.0, 128.0, 0.0]
green | [0.0, 128.0, 0.0]
color:text
green
olive
;

knnWithNegatedPrefilter
Expand Down